kernel.git/drivers/crypto/hisilicon/zip, branch linux-5.10.y

crypto: hisilicon/zip - fix mismatch in get/set sgl_sge_nr

2022-10-26T11:25:41Z

[ Upstream commit d74f9340097a881869c4c22ca376654cc2516ecc ] KASAN reported this Bug: [17619.659757] BUG: KASAN: global-out-of-bounds in param_get_int+0x34/0x60 [17619.673193] Read of size 4 at addr fffff01332d7ed00 by task read_all/1507958 ... [17619.698934] The buggy address belongs to the variable: [17619.708371] sgl_sge_nr+0x0/0xffffffffffffa300 [hisi_zip] There is a mismatch in hisi_zip when get/set the variable sgl_sge_nr. The type of sgl_sge_nr is u16, and get/set sgl_sge_nr by param_get/set_int. Replacing param_get/set_int to param_get/set_ushort can fix this bug. Fixes: f081fda293ffb ("crypto: hisilicon - add sgl_sge_nr module param for zip") Signed-off-by: Ye Weihua Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin

crypto: hisilicon/zip - fix the uninitalized 'curr_qm_qp_num'

2020-10-02T08:02:14Z

The 'qm->curr_qm_qp_num' is not initialized, which will result in failure to write the current_q file. Signed-off-by: Sihang Chen Signed-off-by: Yang Shen Reviewed-by: Zhou Wang Signed-off-by: Herbert Xu

crypto: hisilicon/zip - fix the return value when device is busy

2020-10-02T08:02:14Z

As before, when the ZIP device is too busy to creat a request, it will return '-EBUSY'. But the crypto process think the '-EBUSY' means a successful request and wait for its completion. So replace '-EBUSY' with '-EAGAIN' to show crypto this request is failed. Fixes: 62c455ca853e("crypto: hisilicon - add HiSilicon ZIP...") Signed-off-by: Yang Shen Reviewed-by: Zhou Wang Signed-off-by: Herbert Xu

crypto: hisilicon/zip - fix zero length input in GZIP decompress

2020-10-02T08:02:13Z

The zero length input will cause a call trace when use GZIP decompress like this: Unable to handle kernel paging request at virtual address ... lr : get_gzip_head_size+0x7c/0xd0 [hisi_zip] Judge the input length and return '-EINVAL' when input is invalid. Fixes: 62c455ca853e("crypto: hisilicon - add HiSilicon ZIP...") Signed-off-by: Zhou Wang Signed-off-by: Yang Shen Signed-off-by: Herbert Xu

crypto: hisilicon/zip - fix the uncleared debug registers

2020-10-02T08:02:13Z

ZIP debug registers aren't cleared even if its driver is removed, so add a clearing operation when remove driver. Signed-off-by: Hao Fang Signed-off-by: Yang Shen Reviewed-by: Zhou Wang Signed-off-by: Herbert Xu

crypto: hisilicon/qm - fix wrong return type of 'pci_get_drvdata'

2020-09-25T07:48:53Z

The parameter type of 'pci_set_drvdata' is 'struct hisi_qm', so here the return type of 'pci_get_drvdata' should be 'struct hisi_qm' too. Signed-off-by: Yang Shen Signed-off-by: Weili Qian Reviewed-by: Zhou Wang Signed-off-by: Herbert Xu

crypto: hisilicon - update ZIP module parameter description

2020-09-18T07:20:11Z

In order to pass kernel CRYPTO test, ZIP module parameter 'pf_q_num' needs to be set as greater than 1. Signed-off-by: Longfang Liu Signed-off-by: Herbert Xu

crypto: hisilicon/zip - fix some coding styles

2020-09-18T07:20:10Z

1.Unified alignment styles 2.Remove unnecessary goto branch 3.Remove address printf Signed-off-by: Yang Shen Reviewed-by: Zhou Wang Signed-off-by: Herbert Xu

crypto: hisilicon/zip - supplement some comments

2020-09-18T07:20:09Z

Supplement some comments. Signed-off-by: Yang Shen Reviewed-by: Zhou Wang Signed-off-by: Herbert Xu

crypto: hisilicon/zip - move some private macros from 'zip.h' to 'zip_crypto.c'

2020-09-18T07:20:09Z

Some macros which are defined in 'zip.h' are related to the struct 'hisi_zip_sqe' and are only used in 'zip_crypto.c'. So move them from 'zip.h' to 'zip_crypto.c'. Signed-off-by: Yang Shen Reviewed-by: Zhou Wang Signed-off-by: Herbert Xu