kernel.git/drivers/crypto/geode-aes.c, branch linux-5.3.y

crypto: geode-aes - switch to skcipher for cbc(aes) fallback

2019-12-13T07:49:28Z

commit 504582e8e40b90b8f8c58783e2d1e4f6a2b71a3a upstream. Commit 79c65d179a40e145 ("crypto: cbc - Convert to skcipher") updated the generic CBC template wrapper from a blkcipher to a skcipher algo, to get away from the deprecated blkcipher interface. However, as a side effect, drivers that instantiate CBC transforms using the blkcipher as a fallback no longer work, since skciphers can wrap blkciphers but not the other way around. This broke the geode-aes driver. So let's fix it by moving to the sync skcipher interface when allocating the fallback. At the same time, align with the generic API for ECB and CBC by rejecting inputs that are not a multiple of the AES block size. Fixes: 79c65d179a40e145 ("crypto: cbc - Convert to skcipher") Cc: # v4.20+ ONLY Signed-off-by: Ard Biesheuvel Signed-off-by: Florian Bezdeka Signed-off-by: Herbert Xu Signed-off-by: Greg Kroah-Hartman

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152

2019-05-30T18:26:32Z

Based on 1 normalized pattern(s): this program is free software you can redistribute it and or modify it under the terms of the gnu general public license as published by the free software foundation either version 2 of the license or at your option any later version extracted by the scancode license scanner the SPDX license identifier GPL-2.0-or-later has been chosen to replace the boilerplate/reference in 3029 file(s). Signed-off-by: Thomas Gleixner Reviewed-by: Allison Randal Cc: linux-spdx@vger.kernel.org Link: https://lkml.kernel.org/r/20190527070032.746973796@linutronix.de Signed-off-by: Greg Kroah-Hartman

crypto: drop mask=CRYPTO_ALG_ASYNC from 'cipher' tfm allocations

2018-11-20T06:26:55Z

'cipher' algorithms (single block ciphers) are always synchronous, so passing CRYPTO_ALG_ASYNC in the mask to crypto_alloc_cipher() has no effect. Many users therefore already don't pass it, but some still do. This inconsistency can cause confusion, especially since the way the 'mask' argument works is somewhat counterintuitive. Thus, just remove the unneeded CRYPTO_ALG_ASYNC flags. This patch shouldn't change any actual behavior. Signed-off-by: Eric Biggers Signed-off-by: Herbert Xu

crypto: geode-aes - fixed coding style warnings and error

2017-07-18T10:15:57Z

fixed WARNING: Block comments should align the * on each line fixed WARNINGs: Missing a blank line after declarations fixed ERROR: space prohibited before that ',' (ctx:WxE) Signed-off-by: Chris Gorman Signed-off-by: Herbert Xu

crypto: geode - Don't use tfm->__crt_alg->cra_name directly

2014-05-22T13:03:13Z

Use a standard accessor instead of directly digging into a structure. Signed-off-by: Marek Vasut Signed-off-by: Herbert Xu

crypto: geode - Weed out printk() from probe()

2014-05-22T13:03:12Z

Signed-off-by: Marek Vasut Cc: Benjamin Herrenschmidt Cc: Dmitry Kasatkin Cc: Eric Bénard Cc: Jussi Kivilinna Cc: Kent Yoder Cc: Michal Ludvig Cc: Varun Wadekar Cc: Vladimir Zapolskiy Cc: linux-geode@lists.infradead.org Signed-off-by: Herbert Xu

crypto: geode - Kill AES_IV_LENGTH

2014-05-22T13:03:11Z

The AES IV length is always 128bits, just use the define from aes.h Signed-off-by: Marek Vasut Cc: Benjamin Herrenschmidt Cc: Dmitry Kasatkin Cc: Eric Bénard Cc: Jussi Kivilinna Cc: Kent Yoder Cc: Michal Ludvig Cc: Varun Wadekar Cc: Vladimir Zapolskiy Cc: linux-geode@lists.infradead.org Signed-off-by: Herbert Xu

crypto: geode - Kill AES_MIN_BLOCK_SIZE

2014-05-22T13:03:11Z

This is actually defined in include/crypto/aes.h , no need to have a a different symbol for the same thing twice. Signed-off-by: Marek Vasut Cc: Benjamin Herrenschmidt Cc: Dmitry Kasatkin Cc: Eric Bénard Cc: Jussi Kivilinna Cc: Kent Yoder Cc: Michal Ludvig Cc: Varun Wadekar Cc: Vladimir Zapolskiy Cc: linux-geode@lists.infradead.org Signed-off-by: Herbert Xu

Drivers: crypto: remove __dev* attributes.

2013-01-03T23:57:02Z

CONFIG_HOTPLUG is going away as an option. As a result, the __dev* markings need to be removed. This change removes the use of __devinit, __devexit_p, __devinitdata, and __devexit from these drivers. Based on patches originally written by Bill Pemberton, but redone by me in order to handle some of the coding style issues better, by hand. Cc: Bill Pemberton Cc: Herbert Xu Cc: "David S. Miller" Cc: Kent Yoder Cc: Jamie Iles Cc: Kim Phillips Cc: Shengzhou Liu Cc: Alex Porosanu Signed-off-by: Greg Kroah-Hartman

crypto: geode-aes - Use module_pci_driver

2012-09-06T20:17:03Z

module_pci_driver makes the code simpler by eliminating module_init and module_exit calls. Signed-off-by: Sachin Kamat Signed-off-by: Herbert Xu