kernel.git/drivers/crypto/ccree/cc_pm.c, branch linux-5.4.yHosts the 0x221E linux distro kernel.
https://git.0xinfinity.dev/distro/kernel.git/atom?h=linux-5.4.y2020-02-11T12:35:22Zcrypto: ccree - fix PM race condition2020-02-11T12:35:22ZGilad Ben-Yossef2020-01-16T10:14:43Zurn:sha1:5f63963669ec54ec5c36227e55f825f911bfaa90
commit 15fd2566bf54ee4d4781d8f170acfc9472a1541f upstream.
The PM code was racy, possibly causing the driver to submit
requests to a powered down device. Fix the race and while
at it simplify the PM code.
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Fixes: 1358c13a48c4 ("crypto: ccree - fix resume race condition on init")
Cc: stable@kernel.org # v4.20
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
crypto: ccree - fix pm wrongful error reporting2020-02-11T12:35:22ZGilad Ben-Yossef2020-01-16T10:14:40Zurn:sha1:d8760030e7017558faa748ba62376be5ab6babf1
commit cedca59fae5834af8445b403c66c9953754375d7 upstream.
pm_runtime_get_sync() can return 1 as a valid (none error) return
code. Treat it as such.
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: stable@vger.kernel.org # v4.19+
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
crypto: ccree - drop legacy ivgen support2019-07-26T04:51:55ZGilad Ben-Yossef2019-07-02T11:39:18Zurn:sha1:e6e6600c001c3aa3760aeb83dbd4630063e926ee
ccree had a mechanism for IV generation which was not compatible
with the Linux seqiv or echainiv iv generator and was never used
in any of the upstream versions so drop all the code implementing it.
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto: ccree - prevent isr handling in case driver is suspended2019-06-27T06:28:00ZOfir Drang2019-06-17T08:46:29Zurn:sha1:3db617e77ae2f8051fd6f5d3fff0e15f086d5b4c
ccree irq may be shared with other devices, in order to prevent ccree isr
handling while device maybe suspended we added a check to verify that the
device is not suspended.
Signed-off-by: Ofir Drang <ofir.drang@arm.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto: ccree - check that cryptocell reset completed2019-06-27T06:28:00ZOfir Drang2019-06-17T08:46:28Zurn:sha1:d84f6269ce24eb4c468e246b24fc0fdce34ab6f6
In case of driver probe and pm resume we need to check that the cryptocell
hardware reset cycle is completed. during the reset cycle that Cryptocell
provide read only access to the APB interface which allows to verify
through the CC registers that the reset is completed. Until reset
completion we assume that any write/crypto operation is blocked.
Signed-off-by: Ofir Drang <ofir.drang@arm.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto: ccree - handle tee fips error during power management resume2019-04-25T07:38:16ZOfir Drang2019-04-18T13:39:10Zurn:sha1:7138377ce10455b7183c6dde4b2c51b33f464c45
in order to support cryptocell tee fips error that may occurs while
cryptocell ree is suspended, an cc_tee_handle_fips_error call added
to the cc_pm_resume function.
Signed-off-by: Ofir Drang <ofir.drang@arm.com>
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: stable@vger.kernel.org # v4.19+
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto: ccree - HOST_POWER_DOWN_EN should be the last CC access during suspend2019-04-25T07:38:16ZOfir Drang2019-04-18T13:39:08Zurn:sha1:3499efbeed39d114873267683b9e776bcb34b058
During power management suspend the driver need to prepare the device
for the power down operation and as a last indication write to the
HOST_POWER_DOWN_EN register which signals to the hardware that
The ccree is ready for power down.
Signed-off-by: Ofir Drang <ofir.drang@arm.com>
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: stable@vger.kernel.org # v4.19+
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto: ccree - pm resume first enable the source clk2019-04-25T07:38:16ZOfir Drang2019-04-18T13:39:06Zurn:sha1:7766dd774d80463cec7b81d90c8672af91de2da1
On power management resume function first enable the device clk source
to allow access to the device registers.
Signed-off-by: Ofir Drang <ofir.drang@arm.com>
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: stable@vger.kernel.org # v4.19+
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto: ccree - copyright header update2019-04-25T07:38:14ZGilad Ben-Yossef2019-04-18T13:38:53Zurn:sha1:03963caeb0dd77b1ead84a5ec913a7d28e8fe816
This sacrificial copyright header update is offered to the legal department
as atonement for any changes made in this driver files in the course of
the current year which have not been duly recorded as such.
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto: ccree - fix resume race condition on init2019-02-08T07:28:02ZGilad Ben-Yossef2019-02-07T13:36:11Zurn:sha1:1358c13a48c43f5e4de0c1835291837a27b9720c
We were enabling autosuspend, which is using data set by the
hash module, prior to the hash module being inited, casuing
a crash on resume as part of the startup sequence if the race
was lost.
This was never a real problem because the PM infra was using low
res timers so we were always winning the race, until commit 8234f6734c5d
("PM-runtime: Switch autosuspend over to using hrtimers") changed that :-)
Fix this by seperating the PM setup and enablement and doing the
latter only at the end of the init sequence.
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: Vincent Guittot <vincent.guittot@linaro.org>
Cc: stable@kernel.org # v4.20
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>