kernel.git/drivers/crypto/ccree/cc_aead.c, branch linux-5.4.yHosts the 0x221E linux distro kernel.
https://git.0xinfinity.dev/distro/kernel.git/atom?h=linux-5.4.y2020-02-11T12:35:22Zcrypto: ccree - fix AEAD decrypt auth fail2020-02-11T12:35:22ZGilad Ben-Yossef2020-01-16T10:14:38Zurn:sha1:70439e8b7ccfe70b810d98bb441c37e5c43ef8c1
commit 2a6bc713f1cef32e39e3c4e6f2e1a9849da6379c upstream.
On AEAD decryption authentication failure we are suppose to
zero out the output plaintext buffer. However, we've missed
skipping the optional associated data that may prefix the
ciphertext. This commit fixes this issue.
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Fixes: e88b27c8eaa8 ("crypto: ccree - use std api sg_zero_buffer")
Cc: stable@vger.kernel.org
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
crypto: ccree/des - switch to new verification routines2019-08-22T04:39:40ZArd Biesheuvel2019-08-15T09:00:52Zurn:sha1:00cd6b233fc89463d4f4eddeb9abf1e009cc09c0
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto: ccree - use std api sg_zero_buffer2019-08-09T05:05:31ZGilad Ben-Yossef2019-07-29T10:40:19Zurn:sha1:e88b27c8eaa8f3126791778803dd2fdd81828f5c
Replace internal cc_zero_sgl() with kernel API of the same function
sg_zero_buffer().
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto: ccree - use the full crypt length value2019-08-09T05:05:30ZGilad Ben-Yossef2019-07-29T10:40:18Zurn:sha1:7a4be6c113c1f721818d1e3722a9015fe393295c
In case of AEAD decryption verifcation error we were using the
wrong value to zero out the plaintext buffer leaving the end of
the buffer with the false plaintext.
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Fixes: ff27e85a85bb ("crypto: ccree - add AEAD support")
CC: stable@vger.kernel.org # v4.17+
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto: ccree - check assoclen for rfc45432019-07-27T11:08:36ZIuliana Prodan2019-07-19T07:09:23Zurn:sha1:b93ecf4296742c36192621645f59e4a607263233
Check assoclen to solve the extra tests that expect -EINVAL to be
returned when the associated data size is not valid.
Validated assoclen for RFC4543 which expects an assoclen
of 16 or 20, the same as RFC4106.
Based on seqiv, IPsec ESP and RFC4543/RFC4106 the assoclen is sizeof
IP Header (spi, seq_no, extended seq_no) and IV len. This can be 16 or
20 bytes.
Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto: ccree - drop legacy ivgen support2019-07-26T04:51:55ZGilad Ben-Yossef2019-07-02T11:39:18Zurn:sha1:e6e6600c001c3aa3760aeb83dbd4630063e926ee
ccree had a mechanism for IV generation which was not compatible
with the Linux seqiv or echainiv iv generator and was never used
in any of the upstream versions so drop all the code implementing it.
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto: ccree - don't map AEAD key and IV on stack2019-04-25T07:38:16ZGilad Ben-Yossef2019-04-18T13:39:05Zurn:sha1:e8662a6a5f8f7f2cadc0edb934aef622d96ac3ee
The AEAD authenc key and IVs might be passed to us on stack. Copy it to
a slab buffer before mapping to gurantee proper DMA mapping.
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: stable@vger.kernel.org # v4.19+
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto: ccree - don't mangle the request assoclen2019-04-25T07:38:15ZGilad Ben-Yossef2019-04-18T13:38:59Zurn:sha1:da3cf67f1bcf25b069a54ff70fd108860242c8f7
We were mangling the request struct assoclen field.
Fix it by keeping an internal version and working on it.
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto: ccree - remove unused defines2019-04-25T07:38:15ZGilad Ben-Yossef2019-04-18T13:38:56Zurn:sha1:bd233baf223d818aea7336a6702322fc1fbb7a4d
Remove unused definitions from AEAD driver code.
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
crypto: ccree - do not copy zero size MLLI table2019-04-25T07:38:15ZGilad Ben-Yossef2019-04-18T13:38:55Zurn:sha1:d2d34fb560ee5c938468b44429499a0aac4c03f2
When we are given a 0 sized cryptlen and assoclen in
a scatterlist with two entries we were falsely trying to
create a zero length MLLI table, causing the HW to choke.
Don't try to copy a zero sized MLLI table.
Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>