kernel.git/drivers/bluetooth/btrtl.c, branch linux-5.6.y

Bluetooth: btrtl: Use kvmalloc for FW allocations

2020-01-24T18:57:53Z

Currently, kmemdup is applied to the firmware data, and it invokes kmalloc under the hood. The firmware size and patch_length are big (more than PAGE_SIZE), and on some low-end systems (like ASUS E202SA) kmalloc may fail to allocate a contiguous chunk under high memory usage and fragmentation: Bluetooth: hci0: RTL: examining hci_ver=06 hci_rev=000a lmp_ver=06 lmp_subver=8821 Bluetooth: hci0: RTL: rom_version status=0 version=1 Bluetooth: hci0: RTL: loading rtl_bt/rtl8821a_fw.bin kworker/u9:2: page allocation failure: order:4, mode:0x40cc0(GFP_KERNEL|__GFP_COMP), nodemask=(null),cpuset=/,mems_allowed=0 As firmware load happens on each resume, Bluetooth will stop working after several iterations, when the kernel fails to allocate an order-4 page. This patch replaces kmemdup with kvmalloc+memcpy. It's not required to have a contiguous chunk here, because it's not mapped to the device directly. Signed-off-by: Maxim Mikityanskiy Signed-off-by: Marcel Holtmann

Bluetooth: btrtl: remove unneeded semicolon

2019-10-26T05:23:30Z

Remove unneeded semicolon. This is detected by coccinelle. Signed-off-by: YueHaibing Signed-off-by: Marcel Holtmann

Bluetooth: btrtl: Fix an issue for the incorrect error return code.

2019-10-16T17:26:40Z

It does not need the '-' for PTR_ERR(skb) because PTR_ERR(skb) will return the negative value during errors. Signed-off-by: Max Chou Signed-off-by: Marcel Holtmann

Bluetooth: btrtl: Fix an issue that failing to download the FW which size is over 32K bytes

2019-09-05T15:27:32Z

Fix the issue that when the FW size is 32K+, it will fail for the download process because of the incorrect index. When firmware patch length is over 32K, "dl_cmd->index" may >= 0x80. It will be thought as "data end" that download process will not complete. However, driver should recount the index from 1. Signed-off-by: Max Chou Signed-off-by: Marcel Holtmann

Bluetooth: btrtl: Remove trailing newline from calls to rtl_dev macros

2019-09-05T15:27:22Z

These printing macros already add a trailing newline, so drop these unnecessary additional newlines. Signed-off-by: Alex Lu Signed-off-by: Marcel Holtmann

Bluetooth: btrtl: Remove redundant prefix from calls to rtl_dev macros

2019-09-05T15:27:22Z

the rtl: or RTL: prefix in the string is pointless. The rtl_dev_* macros already does that. Signed-off-by: Alex Lu Signed-off-by: Marcel Holtmann

Bluetooth: btrtl: Add firmware version print

2019-09-05T15:27:22Z

This patch is used to print fw version for debug convenience Signed-off-by: Alex Lu Signed-off-by: Marcel Holtmann

Bluetooth: btrtl: Set HCI_QUIRK_SIMULTANEOUS_DISCOVERY

2019-09-05T15:27:22Z

Realtek Bluetooth controllers can do both LE scan and BR/EDR inquiry at once, need to set HCI_QUIRK_SIMULTANEOUS_DISCOVERY quirk. Signed-off-by: Alex Lu Signed-off-by: Marcel Holtmann

Bluetooth:: btrtl: Add support for RTL8723DU

2019-07-06T11:00:58Z

This device is functionally equivalent to the BT part of the RTL8723DE, uses the same firmware, but the LMP subversion and HCI revision are unique. Signed-off-by: Larry Finger Signed-off-by: Marcel Holtmann

Bluetooth: btrtl: HCI reset on close for Realtek BT chip

2019-07-06T10:32:50Z

Realtek RTL8822BE BT chip on ASUS X420FA cannot be turned on correctly after on-off several times. Bluetooth daemon sets BT mode failed when this issue happens. Scanning must be active while turning off for this bug to be hit. bluetoothd[1576]: Failed to set mode: Failed (0x03) If BT is turned off, then turned on again, it works correctly again. According to the vendor driver, the HCI_QUIRK_RESET_ON_CLOSE flag is set during probing. So, this patch makes Realtek's BT reset on close to fix this issue. Link: https://bugzilla.kernel.org/show_bug.cgi?id=203429 Signed-off-by: Jian-Hong Pan Reviewed-by: Daniel Drake Signed-off-by: Marcel Holtmann