kernel.git/drivers/auxdisplay/charlcd.c, branch linux-5.4.y

auxdisplay: charlcd: move charlcd.h to drivers/auxdisplay

2019-08-08T17:59:17Z

This header is included in drivers/auxdisplay/. Make it a local header. Reviewed-by: Geert Uytterhoeven Signed-off-by: Masahiro Yamada Signed-off-by: Miguel Ojeda

auxdisplay: charlcd: make backlight initial state configurable

2019-03-17T07:48:45Z

The charlcd driver currently flashes the backlight once on init. This may not be desirable. Thus, add options for turning the backlight off or on as well. Signed-off-by: Mans Rullgard Signed-off-by: Miguel Ojeda

auxdisplay: charlcd: simplify init message display

2019-03-17T07:48:39Z

If CONFIG_PANEL_CHANGE_MESSAGE is set, CONFIG_PANEL_BOOT_MESSAGE will also be defined, so the double ifdef is pointless. Simplify the code further by using an intermediate macro rather duplicating most of the line. Signed-off-by: Mans Rullgard Signed-off-by: Miguel Ojeda

auxdisplay: charlcd: Introduce charlcd_free() helper

2019-03-17T07:48:16Z

The charlcd_free() is a counterpart to charlcd_alloc() and should be called symmetrically on tear down. Reviewed-by: Geert Uytterhoeven Signed-off-by: Andy Shevchenko Signed-off-by: Miguel Ojeda

auxdisplay: charlcd: Move to_priv() to charlcd namespace

2019-03-17T07:48:10Z

In order to be more particular in names, rename to_priv() macro to charlcd_to_priv(). No functional change intended. Reviewed-by: Geert Uytterhoeven Signed-off-by: Andy Shevchenko Signed-off-by: Miguel Ojeda

auxdisplay: charlcd: fix x/y command parsing

2018-12-21T20:27:21Z

The x/y command parsing has been broken since commit 129957069e6a ("staging: panel: Fixed checkpatch warning about simple_strtoul()"). Commit b34050fadb86 ("auxdisplay: charlcd: Fix and clean up handling of x/y commands") fixed some problems by rewriting the parsing code, but also broke things further by removing the check for a complete command before attempting to parse it. As a result, parsing is terminated at the first x or y character. This reinstates the check for a final semicolon. Whereas the original code use strchr(), this is wasteful seeing as the semicolon is always at the end of the buffer. Thus check this character directly instead. Signed-off-by: Mans Rullgard Signed-off-by: Miguel Ojeda

auxdisplay: charlcd: delete mdelay in long_sleep

2018-08-01T16:55:36Z

The function long_sleep() calls mdelay() when in an interrupt handler. But only charlcd_clear_display() and charlcd_init_display calls long_sleep(), and my tool finds that the two functions are never called in an interrupt handler. Thus mdelay() and in_interrupt() are not necessary. This is found by a static analysis tool named DCNS written by myself. Signed-off-by: Jia-Ju Bai Acked-by: Willy Tarreau Signed-off-by: Miguel Ojeda

auxdisplay: Replace licenses with SPDX identifiers

2018-04-12T17:02:45Z

Cc: Philippe Ombredanne Acked-by: Willy Tarreau Acked-by: Linus Walleij Acked-by: Robin van der Gracht Acked-by: Geert Uytterhoeven Signed-off-by: Miguel Ojeda

auxdisplay: charlcd: Fix and clean up handling of x/y commands

2018-04-12T17:02:44Z

The current version is not parsing multiple x/y commands as the code originally intended. On top of that, kstrtoul() expects NULL-terminated strings. Finally, the code does two passes over the string. Some explanations about the supported syntax are added as well. Cc: Willy Tarreau Cc: Geert Uytterhoeven Cc: Andy Shevchenko Cc: Robert Abel Signed-off-by: Miguel Ojeda

auxdisplay: charlcd: fix hex literal ranges for graphics command

2018-04-12T17:02:44Z

The graphics command expects 16 hexadecimal literals, but would allow characters in range [0-9a-zA-Z] instead of [0-9a-fA-F]. Signed-off-by: Robert Abel Acked-by: Willy Tarreau Reviewed-by: Geert Uytterhoeven Signed-off-by: Miguel Ojeda