kernel.git/drivers/auxdisplay/charlcd.c, branch linux-4.19.y

auxdisplay: charlcd: fix x/y command parsing

2019-01-13T08:51:03Z

[ Upstream commit 9bc30ab82108e6a34dc63bf956b49edf71b1681a ] The x/y command parsing has been broken since commit 129957069e6a ("staging: panel: Fixed checkpatch warning about simple_strtoul()"). Commit b34050fadb86 ("auxdisplay: charlcd: Fix and clean up handling of x/y commands") fixed some problems by rewriting the parsing code, but also broke things further by removing the check for a complete command before attempting to parse it. As a result, parsing is terminated at the first x or y character. This reinstates the check for a final semicolon. Whereas the original code use strchr(), this is wasteful seeing as the semicolon is always at the end of the buffer. Thus check this character directly instead. Signed-off-by: Mans Rullgard Signed-off-by: Miguel Ojeda Signed-off-by: Sasha Levin

auxdisplay: charlcd: delete mdelay in long_sleep

2018-08-01T16:55:36Z

The function long_sleep() calls mdelay() when in an interrupt handler. But only charlcd_clear_display() and charlcd_init_display calls long_sleep(), and my tool finds that the two functions are never called in an interrupt handler. Thus mdelay() and in_interrupt() are not necessary. This is found by a static analysis tool named DCNS written by myself. Signed-off-by: Jia-Ju Bai Acked-by: Willy Tarreau Signed-off-by: Miguel Ojeda

auxdisplay: Replace licenses with SPDX identifiers

2018-04-12T17:02:45Z

Cc: Philippe Ombredanne Acked-by: Willy Tarreau Acked-by: Linus Walleij Acked-by: Robin van der Gracht Acked-by: Geert Uytterhoeven Signed-off-by: Miguel Ojeda

auxdisplay: charlcd: Fix and clean up handling of x/y commands

2018-04-12T17:02:44Z

The current version is not parsing multiple x/y commands as the code originally intended. On top of that, kstrtoul() expects NULL-terminated strings. Finally, the code does two passes over the string. Some explanations about the supported syntax are added as well. Cc: Willy Tarreau Cc: Geert Uytterhoeven Cc: Andy Shevchenko Cc: Robert Abel Signed-off-by: Miguel Ojeda

auxdisplay: charlcd: fix hex literal ranges for graphics command

2018-04-12T17:02:44Z

The graphics command expects 16 hexadecimal literals, but would allow characters in range [0-9a-zA-Z] instead of [0-9a-fA-F]. Signed-off-by: Robert Abel Acked-by: Willy Tarreau Reviewed-by: Geert Uytterhoeven Signed-off-by: Miguel Ojeda

auxdisplay: charlcd: fix two-line command ^[[LN not marked as processed

2018-04-12T17:02:43Z

Signed-off-by: Robert Abel Reviewed-by: Geert Uytterhoeven Signed-off-by: Miguel Ojeda

auxdisplay: charlcd: replace octal literal with form-feed escape sequence

2018-04-12T17:02:43Z

There is no need to resort to octal escape sequence for the form feed character when an established escape sequence exists. Signed-off-by: Robert Abel Signed-off-by: Miguel Ojeda

auxdisplay: charlcd: use null character instead of zero literal to terminate strings

2018-04-12T17:02:43Z

Using '\0' instead of plain 0 makes the intent clearer that this is indeed a string and not a series of integers. Signed-off-by: Robert Abel Signed-off-by: Miguel Ojeda

auxdisplay: charlcd: no need to call charlcd_gotoxy() if nothing changes

2018-04-12T17:02:42Z

If the line extends beyond the width to the screen, nothing changes. The existing code will call charlcd_gotoxy every time for this case. Signed-off-by: Sean Young Reviewed-by: Geert Uytterhoeven Signed-off-by: Miguel Ojeda

auxdisplay: charlcd: properly restore atomic counter on error path

2017-09-18T14:06:00Z

Commit f4757af ("staging: panel: Fix single-open policy race condition") introduced in 3.19-rc1 attempted to fix a race condition on the open, but failed to properly do it and used to exit without restoring the semaphore. This results in -EBUSY being returned after the first open error until the module is reloaded or the system restarted (ie: consecutive to a dual open resulting in -EBUSY or to a permission error). [ Note for stable maintainers: the code moved from drivers/misc/panel.c to drivers/auxdisplay/{charlcd,panel}.c during 4.12. The patch easily applies there (modulo the renamed atomic counter) but I can provide a tested backport if desired. ] Fixes: f4757af85 # 3.19-rc1 Cc: stable@vger.kernel.org Cc: Mariusz Gorski Cc: Geert Uytterhoeven Cc: Miguel Ojeda Sandonis Signed-off-by: Willy Tarreau Signed-off-by: Greg Kroah-Hartman