kernel.git/drivers/atm/he.c, branch linux-4.4.y

atm: he: fix sign-extension overflow on large shift

2019-03-23T07:44:16Z

[ Upstream commit cb12d72b27a6f41325ae23a11033cf5fedfa1b97 ] Shifting the 1 by exp by an int can lead to sign-extension overlow when exp is 31 since 1 is an signed int and sign-extending this result to an unsigned long long will set the upper 32 bits. Fix this by shifting an unsigned long. Detected by cppcheck: (warning) Shifting signed 32-bit value by 31 bits is undefined behaviour Signed-off-by: Colin Ian King Signed-off-by: David S. Miller Signed-off-by: Sasha Levin

atm: he: drop null test before destroy functions

2015-09-15T23:49:43Z

Remove unneeded NULL test. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression x; @@ -if (x != NULL) \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x); // Signed-off-by: Julia Lawall Signed-off-by: David S. Miller

atm:he - Do not initialise statics to 0.

2015-06-04T22:43:10Z

According to false is always '0' and Static variables are initialised to 0 by GCC. Signed-off-by: Shailendra Verma Signed-off-by: David S. Miller

atm:he - Change 1 to true for bool type variable.

2015-05-25T20:34:35Z

The variable irq_coalesce is bool type. So assign the value true instead of 1. Signed-off-by: Shailendra Verma Signed-off-by: David S. Miller

atm: remove deprecated use of pci api

2015-01-18T05:28:41Z

Signed-off-by: Chas Williams - CONTRACTOR Signed-off-by: David S. Miller

atm: use pci_zalloc_consistent

2014-08-08T22:57:28Z

Remove the now unnecessary memset too. Signed-off-by: Joe Perches Cc: Chas Williams Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

atm: he: remove unnecessary pci_set_drvdata()

2013-12-11T03:31:32Z

The driver core clears the driver data to NULL after device_release or on probe failure. Thus, it is not needed to manually clear the device driver data to NULL. Signed-off-by: Jingoo Han Signed-off-by: David S. Miller

drivers/atm/he.c: convert to module_pci_driver

2013-09-14T00:02:50Z

Signed-off-by: Libo Chen Cc: Chas Williams Signed-off-by: Andrew Morton Signed-off-by: David S. Miller

atm: he: print MAC via %pM

2013-09-04T18:41:55Z

Signed-off-by: Andy Shevchenko Signed-off-by: David S. Miller

atm: he: use mdelay instead of large udelay constants

2013-04-29T17:26:48Z

ARM cannot handle udelay for more than 2 miliseconds, and it is rather bad style to block the cpu for 16ms anyway, so let's use msleep instead. Signed-off-by: Arnd Bergmann Cc: Chas Williams Cc: linux-atm-general@lists.sourceforge.net Cc: netdev@vger.kernel.org Signed-off-by: David S. Miller