kernel.git/arch/mips/alchemy, branch linux-5.18.y

mips: alchemy: remove historic comment on gpio build constraints

2021-12-16T14:48:32Z

In ./arch/mips/alchemy/common/gpiolib.c, the comment points out certain build constraints on CONFIG_GPIOLIB and CONFIG_ALCHEMY_GPIO_INDIRECT. The commit 832f5dacfa0b ("MIPS: Remove all the uses of custom gpio.h") makes all mips machines use the common gpio.h and removes the config ALCHEMY_GPIO_INDIRECT. So, this makes the comment in alchemy's gpiolib.c historic and obsolete, and can be removed after the commit above. The issue on the reference to a non-existing Kconfig symbol was identified with ./scripts/checkkconfigsymbols.py. This script has been quite useful to identify a number of bugs with Kconfig symbols and deserves to be executed and checked regularly. So, remove the historic comment to reduce the reports made the script and simplify to use this script, as new issues are easier to spot when the list of reports is shorter. Signed-off-by: Lukas Bulwahn Signed-off-by: Thomas Bogendoerfer

MIPS: Fix fall-through warnings for Clang

2021-10-13T19:47:42Z

Fix the following fallthrough warnings: arch/mips/alchemy/devboards/db1550.c:69:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough] case BCSR_WHOAMI_DB1550: ^ arch/mips/alchemy/devboards/db1550.c:69:2: note: insert 'break;' to avoid fall-through case BCSR_WHOAMI_DB1550: ^ break; arch/mips/kernel/uprobes.c:176:2: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough] default: ^ arch/mips/kernel/uprobes.c:176:2: note: insert 'break;' to avoid fall-through default: ^ break; This helps with the ongoing efforts to globally enable -Wimplicit-fallthrough for Clang. Link: https://github.com/KSPP/linux/issues/115 Link: https://lore.kernel.org/linux-mm/202109030839.t2llsvmc-lkp@intel.com/ Link: https://lore.kernel.org/linux-mm/202108271617.MHxFd8aX-lkp@intel.com/ Reported-by: kernel test robot Signed-off-by: Gustavo A. R. Silva

MIPS: Alchemy: Fix spelling contraction "cant" -> "can't"

2021-07-29T09:41:05Z

There is a spelling mistake in a pr_warn message. Fix it. Signed-off-by: Colin Ian King Signed-off-by: Thomas Bogendoerfer

MIPS: alchemy: xxs1500: add gpio-au1000.h header file

2021-05-25T13:16:23Z

board-xxs1500.c references 2 functions without declaring them, so add the header file to placate the build. ../arch/mips/alchemy/board-xxs1500.c: In function 'board_setup': ../arch/mips/alchemy/board-xxs1500.c:56:2: error: implicit declaration of function 'alchemy_gpio1_input_enable' [-Werror=implicit-function-declaration] 56 | alchemy_gpio1_input_enable(); ../arch/mips/alchemy/board-xxs1500.c:57:2: error: implicit declaration of function 'alchemy_gpio2_enable'; did you mean 'alchemy_uart_enable'? [-Werror=implicit-function-declaration] 57 | alchemy_gpio2_enable(); Fixes: 8e026910fcd4 ("MIPS: Alchemy: merge GPR/MTX-1/XXS1500 board code into single files") Signed-off-by: Randy Dunlap Cc: Thomas Bogendoerfer Cc: linux-mips@vger.kernel.org Cc: Manuel Lauss Cc: Ralf Baechle Acked-by: Manuel Lauss Signed-off-by: Thomas Bogendoerfer

MIPS: Alchemy: Use DEFINE_SPINLOCK() for spinlock

2021-04-12T14:54:57Z

spinlock can be initialized automatically with DEFINE_SPINLOCK() rather than explicitly calling spin_lock_init(). Reported-by: Hulk Robot Signed-off-by: Lifu Chen Signed-off-by: Thomas Bogendoerfer

driver core: lift dma_default_coherent into common code

2021-02-13T08:51:45Z

Lift the dma_default_coherent variable from the mips architecture code to the driver core. This allows an architecture to sdefault all device to be DMA coherent at run time, even if the kernel is build with support for DMA noncoherent device. By allowing device_initialize to set the ->dma_coherent field to this default the amount of arch hooks required for this behavior can be greatly reduced. Signed-off-by: Christoph Hellwig Acked-by: Greg Kroah-Hartman Signed-off-by: Thomas Bogendoerfer

MIPS: refactor the runtime coherent vs noncoherent DMA indicators

2021-02-13T08:51:45Z

Replace the global coherentio enum, and the hw_coherentio (fake) boolean variables with a single boolean dma_default_coherent flag. Signed-off-by: Christoph Hellwig Signed-off-by: Thomas Bogendoerfer

MIPS/alchemy: factor out the DMA coherent setup

2021-02-13T08:51:45Z

Factor out a alchemy_dma_coherent helper that determines if the platform is DMA coherent. Also stop initializing the hw_coherentio variable, given that is only ever set to a non-zero value by the malta setup code. Signed-off-by: Christoph Hellwig Signed-off-by: Thomas Bogendoerfer

MIPS: Remove empty prom_free_prom_memory functions

2021-01-07T16:11:33Z

Most of the prom_free_prom_memory functions are empty. With a new weak prom_free_prom_memory() we can remove all of them. Signed-off-by: Thomas Bogendoerfer Acked-by: Florian Fainelli

MIPS: Alchemy: Fix memleak in alchemy_clk_setup_cpu

2020-11-17T11:53:57Z

If the clk_register fails, we should free h before function returns to prevent memleak. Fixes: 474402291a0ad ("MIPS: Alchemy: clock framework integration of onchip clocks") Reported-by: Hulk Robot Signed-off-by: Zhang Qilong Signed-off-by: Thomas Bogendoerfer